Don't recompute runahead unnecessarily in main loop - #7400
Open
hjoliver wants to merge 3 commits into
Open
Conversation
hjoliver
force-pushed
the
tweak-compute_runahead
branch
from
July 24, 2026 03:16
a5648b2 to
0f74adb
Compare
hjoliver
force-pushed
the
tweak-compute_runahead
branch
from
July 24, 2026 03:22
0f74adb to
b37f5cd
Compare
Member
Author
|
(Changed PR branch base several times after accidentally screwing up 8.6.x in my own fork 😬 ) |
Member
Author
|
Lint fail unrelated - see #7403 |
hjoliver
requested review from
MetRonnie and
oliver-sanders
and removed request for
MetRonnie
July 27, 2026 22:09
hjoliver
force-pushed
the
tweak-compute_runahead
branch
2 times, most recently
from
July 28, 2026 02:13
007ce68 to
8a84fed
Compare
8 tasks
hjoliver
force-pushed
the
tweak-compute_runahead
branch
from
July 28, 2026 02:39
8a84fed to
6dd4641
Compare
hjoliver
marked this pull request as ready for review
July 28, 2026 02:45
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up #7237 (see last paragraph of #7237 (comment) )
I did not think that calling
compute_runaheadonce per main loop would be a significant efficiency hit in inactive workflows because the method returns early if the base point hasn't changed. So in inactive workflows it really only does this:HOWEVER, it's certainly better not to call it at all if nothing is happening - so fair call @oliver-sanders and @MetRonnie
Note the change in
task_pool.py(commit 2) is not necessary, it's just to separate out the soon-to-be-gone Cylc 7 compat bit, allowing the Cylc 8 case to be cleaner (and avoids a Python loop).Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.